Skip to content

OpenAI wrapper service review#18

Open
lakshay6666 wants to merge 10 commits into
masterfrom
codex/openai-wrapper-service-review
Open

OpenAI wrapper service review#18
lakshay6666 wants to merge 10 commits into
masterfrom
codex/openai-wrapper-service-review

Conversation

@lakshay6666

@lakshay6666 lakshay6666 commented Jun 8, 2026

Copy link
Copy Markdown
Collaborator

Summary

Adds an OpenAI wrapper service for issue #11.

The service is located under services/openai-wrapper-service and includes:

  • REST endpoints for /generate and /health
  • generated OpenAPI spec
  • CLI command for text generation
  • Dockerfile and Docker build target
  • service Makefile targets
  • GitHub CI workflow
  • README with setup, API key config, and minimal hardware requirements
  • tests with fake adapters, so no OpenAI API calls are made during tests

Notes

The service uses the official OpenAI Python SDK. The API key is read from OPENAI_API_KEY at runtime and is not stored in the repo.

Validation

  • make lint
  • make test
  • make generate-openapi

Closes #11

@lakshay6666 lakshay6666 requested a review from plc-dev June 8, 2026 15:49
@plc-dev

plc-dev commented Jun 9, 2026

Copy link
Copy Markdown
Member

General comments:

  • Preferably use conventional commits to format commit messages, even if not strictly enforced yet by the repo.
  • Create branches that relate to the issue (e.g. by using the provided button within the Github-UI. See
    image and
image
  • Do not create multiple branches per issue. If required, delete stale ones (codex/openai-wrapper-service-review and codex/openai-wrapper-service)
  • There's not necessarily something wrong with using AI to create code, but:
    • make sure you understand the code that was generated, by first reviewing it yourself
    • and before that, ensure that all the requirements have been specified. If you find the issue description is too ambiguous, ask for clarifications by the person who created the issue. If you forego understanding the requirements of the feature, the AI will just produce something anyways, which you then can not validate. This shifts all the effort to the person reviewing the code, which defeats the entire purpose ¯_(ツ)_/¯

Comment thread services/openai-wrapper-service/src/openai_wrapper_service/cli.py Outdated
Comment thread services/openai-wrapper-service/src/openai_wrapper_service/cli.py Outdated
Comment thread services/openai-wrapper-service/src/openai_wrapper_service/cli.py Outdated
Comment thread services/openai-wrapper-service/src/openai_wrapper_service/cli.py Outdated
Comment thread services/openai-wrapper-service/src/openai_wrapper_service/cli.py Outdated
Comment thread services/openai-wrapper-service/src/openai_wrapper_service/cli.py Outdated
Comment thread services/openai-wrapper-service/src/openai_wrapper_service/client.py Outdated
Comment thread services/openai-wrapper-service/src/openai_wrapper_service/config.py Outdated
Comment thread services/openai-wrapper-service/src/openai_wrapper_service/schemas.py Outdated
Comment thread services/openai-wrapper-service/src/openai_wrapper_service/api.py
Comment thread services/openai-wrapper-service/test/test_generate_openapi.py Outdated
Comment thread services/openai-wrapper-service/Dockerfile Outdated
Comment thread services/openai-wrapper-service/src/openai_wrapper_service/client.py Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Integration of a LLM-Connector

2 participants