feat(phoenix-ng): add NotificationService with 4 severity levels and configurable auto-dismiss#895
Open
deveshbervar wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds
NotificationServiceas part of Work Area 1 (WA1).WA1 arc:
What this adds
notification.service.ts— Injectable Angular service:Follows the same
ActiveVariablepattern asErrorMessageService.Components subscribe via
subscribeToNotifications().Default auto-dismiss durations:
success— 5000msinfo— 5000mswarning— 8000mserror— 0ms (manual dismiss required)Custom duration supported via optional second parameter.
notification.service.component.test.ts— 6 tests:Why
PR #879 added try/catch to route IO errors through InfoLogger.
This PR adds the service layer that allows any Phoenix component
to emit user-visible notifications programmatically.
The next step (separate PR) will add the UI component that
subscribes to this service and renders toasts via MatSnackBar.
Scope
phoenix-ui-components/lib/services/index.tsfor export