Skip to content

Improve ARC CE endpoint handling and token audience in IamTokenCredManager#311

Merged
mightqxc merged 3 commits into
masterfrom
flin
May 15, 2026
Merged

Improve ARC CE endpoint handling and token audience in IamTokenCredManager#311
mightqxc merged 3 commits into
masterfrom
flin

Conversation

@mightqxc

Copy link
Copy Markdown
Collaborator

No description provided.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates IamTokenCredManager to better normalize ARC CE endpoints and to adjust the requested token audience (aud) for ARC CEs when renewing IAM access tokens.

Changes:

  • Strip protocol schemes from CRIC-provided CE endpoints before generating token targets/filenames.
  • Persist ce_hostname for ARC CEs and use it to derive an HTTPS-style audience when renewing tokens.
  • Update commit_timestamp.py.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
pandaharvester/harvestercredmanager/iam_token_cred_manager.py Normalizes CE endpoints (scheme removal), adds ARC CE hostname tracking, and adjusts token audience selection logic for ARC CE targets.
pandaharvester/commit_timestamp.py Updates the embedded commit timestamp string.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread pandaharvester/harvestercredmanager/iam_token_cred_manager.py
@mightqxc mightqxc merged commit f44053b into master May 15, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants