chore: delete leftover transforms changeset (already released in 0.5.0)#1012
Open
SnowboardTechie wants to merge 2 commits into
Open
chore: delete leftover transforms changeset (already released in 0.5.0)#1012SnowboardTechie wants to merge 2 commits into
SnowboardTechie wants to merge 2 commits into
Conversation
Drop the proof-of-concept framing and internal issue/PR cross-refs from the lead sentence (by release time this is the shipped transformation framework), and remove the Deferred-to-full-SDK section: changelogs describe what shipped, and the opt-in commonModel behavior it mentioned is already documented in the buildTransforms bullet.
Collaborator
|
@SnowboardTechie Is this changeset a leftover? |
The changeset's content was consumed and published in @common-grants/sdk 0.5.0 (c05db3f, 2026-06-22); the identical text is the CHANGELOG's 0.5.0 entry. The file survived on HOLD-filters because 324809b added a copy on the HOLD side the same day main consumed its own, so main's deletion never propagated. Left in place, it would re-bump the SDK and duplicate the full transforms entry in the next release's changelog. Supersedes the wording pass on the same file.
SnowboardTechie
changed the title
Collaborator
Author
Oh ya that is! It shipped in 0.5.0 but survived on HOLD-filters, so this PR now deletes it instead. |
widal001
approved these changes
Jul 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.changeset/transforms-poc-typescript.md: its content was already consumed and published in@common-grants/sdk0.5.0, so it's a leftover that would re-bump the SDK and duplicate the full transforms entry in the next release's changelog.Changes proposed
.changeset/transforms-poc-typescript.md. (The first commit was a wording pass on the same file, superseded by the deletion — the diff nets out to the removal.)Context for reviewers
Verification: the ts-sdk
CHANGELOG.md0.5.0 entry contains the changeset's text verbatim, consumed at c05db3f (2026-06-22). The file survived onHOLD-filtersbecause 324809b (Hold transforms, #906) added a copy on the HOLD side the same day main consumed its own, so main's deletion never propagated through the subsequent main-into-HOLD merges.Reviewed the rest of the set for the same failure mode: the other changesets (
ts-typed-custom-filters,python-typed-custom-filters,python-sdk-py-typed) all describe unreleased work — none appear in any published CHANGELOG entry — and read as release notes as-is.Additional information
Targets
HOLD-filtersto land before #918.