fix(sdk): drop integerComparison from both SDK filter catalogs#1011
Merged
Conversation
Resolves the integer-vs-number divergence from the PR #988 review thread: Python's IntegerComparisonFilter rejected floats while the TS SDK aliased integerComparison to NumberComparisonFilterSchema and accepted them, so the same registered filter behaved differently per SDK. With the core integer filter model moved off this release, neither SDK ships a filter type the spec does not define: integerComparison is removed from the Python models/exports/catalog and the TS CustomFilterType union and schema map. NumberComparisonFilter already accepts integer values (matching JSON Schema's number type), so integer filtering needs no dedicated type. The catalog is now 10 types, identical across SDKs.
github-actions
Bot
added
python
widal001
approved these changes
Jul 15, 2026
widal001
left a comment
widal001
left a comment
Collaborator
There was a problem hiding this comment.
Thanks for making this change!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
integerComparisonis removed from both SDKs, makingNumberComparisonFilterthe single numeric-comparison type (option 3 from that thread).Changes proposed
IntegerComparisonFilter(model, exports,IntegerComparisonauthoring alias,VALID_FILTER_MODELSentry) and its three tests.integerComparisonfrom theCustomFilterTypeunion, theFILTER_TYPE_SCHEMASmap (it was already just an alias forNumberComparisonFilterSchema), the type fixtures/tests, and the README catalog (now 10 types).Context for reviewers
The divergence: Python's
IntegerComparisonFilterrejected3.5while TS aliasedintegerComparisonto the number schema and accepted it — the same registered filter behaved differently per SDK. Dropping the type entirely (rather than keeping an alias key) leaves the two catalogs identical, and matches the spec state of this release: after 886a384's revert moved the core integer filter model to the v0.4.0 train,integerComparisonhad no spec model behind it.NumberComparisonFilteralready accepts integer values, consistent with JSON Schema'snumbertype. If core v0.4.0 later ships a real integer filter family, the type can return in both SDKs together.Nothing released ships this type and neither grants.gov plugin registers it, so there's no consumer impact; no changeset needed (it removes part of an unreleased addition, and the existing filters changesets don't mention integers).
Verified: Python
make checks+ 396 tests green; TSpnpm run checks+ 546 tests green.Additional information
Targets
HOLD-filtersto land before #918, per the release-train ordering.