Skip to content

lib/rtoolsHCK: Add no_studio mode support#82

Merged
kostyanf14 merged 2 commits into
HCK-CI:masterfrom
elizashurov:add-no-studio-mode
Jun 17, 2026
Merged

lib/rtoolsHCK: Add no_studio mode support#82
kostyanf14 merged 2 commits into
HCK-CI:masterfrom
elizashurov:add-no-studio-mode

Conversation

@elizashurov

Copy link
Copy Markdown
Contributor

Introduce a no_studio initialization option that allows creating an RToolsHCK instance without connecting to the HLK studio. In this mode, WinRM and toolsHCK setup is skipped on initialize and teardown, while studio-only methods (run_on_studio, reconnect, connection_check, close_and_shutdown) raise a clear error if called.

Also fix run_on_machine to always include the content key in the JSON response, even when the command produces no output.

@elizashurov elizashurov requested a review from kostyanf14 June 15, 2026 12:10

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a no_studio mode to rtoolsHCK.rb, allowing the tool to run without initializing studio-related services. It adds manual checks across several methods to raise errors or return early when this mode is active. The review feedback suggests a more robust, centralized approach to handle studio-only methods within handle_action_exceptions using an allowed list of client actions, which would prevent potential NoMethodError exceptions on other unprotected studio-only methods.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread lib/rtoolsHCK.rb Outdated
Introduce a `no_studio` initialization option that allows creating an
RToolsHCK instance without connecting to the HLK studio. In this mode,
WinRM and toolsHCK setup is skipped on initialize and teardown, while
studio-only methods (run_on_studio, reconnect, connection_check,
close_and_shutdown) raise a clear error if called.

Signed-off-by: Elizabeth Ashurov <eashurov@redhat.com>
…onse

Fix run_on_machine to always include the content key in the JSON
response, even when the command produces no output.

Signed-off-by: Elizabeth Ashurov <eashurov@redhat.com>
@kostyanf14 kostyanf14 merged commit d385a41 into HCK-CI:master Jun 17, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants