Skip to content

docs: refresh Getting Started, Home, and Image Installation guides#1001

Open
rachael-george wants to merge 2 commits into
HCK-CI:masterfrom
rachael-george:doc_update
Open

docs: refresh Getting Started, Home, and Image Installation guides#1001
rachael-george wants to merge 2 commits into
HCK-CI:masterfrom
rachael-george:doc_update

Conversation

@rachael-george

Copy link
Copy Markdown

Refresh the core setup and usage docs with step-by-step manual installation guidance, a structured override.json workflow, and corrected configuration references (kits/.json, qemu_machine.json paths).

  • Getting Started — Adds an overview workflow, Fedora/RHEL prerequisite commands, dependency layout (filters/, playlists/, sibling repos), and a detailed override.json guide with validation commands; updates Ruby requirement to ≥ 3.3.0.

  • Home — Syncs the CLI reference with current bin/auto_hck options, documents triggers_check for selective CI, fixes workspace path layout, and updates examples to real platform names.

  • Image Installation — Expands ISO/kit configuration guidance, fixes kit file paths, improves UEFI ISO patching examples, and corrects the install platform example (Win10_2004x86_bios).

Signed-off-by: rachael-george <rgeorge@redhat.com>

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request significantly updates the documentation for AutoHCK, including manual installation steps, configuration guides (focusing on override.json), CLI references, and image installation instructions. The review feedback highlights a few issues in the updated documentation: a potential Ruby version mismatch on RHEL 9, an incorrect path for the swtpm_setup binary in a validation command, a missing closing brace in a JSON example, and the need to mention install.esd as an alternative to install.wim for certain Windows ISOs.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread docs/Getting-Started.md
Comment thread docs/Getting-Started.md Outdated
sudo dnf install -y slirp4netns net-tools ethtool xorriso jq swtpm swtpm-tools
slirp4netns --version
which ifconfig ethtool xorriso jq
test -x /usr/bin/swtpm_setup && echo "swtpm OK"

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

On Fedora and RHEL, the swtpm_setup binary is installed to /usr/sbin/swtpm_setup (by the swtpm-tools package) rather than /usr/bin/swtpm_setup. Using test -x /usr/bin/swtpm_setup will fail to validate the installation. It is recommended to check /usr/sbin/swtpm_setup instead.

Suggested change
test -x /usr/bin/swtpm_setup && echo "swtpm OK"
test -x /usr/sbin/swtpm_setup && echo "swtpm OK"

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed to command -v instead, to be path agnostic

Comment thread docs/Getting-Started.md Outdated
Comment on lines +248 to +249
-> "result_uploaders": [ "dropbox" ]
}

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The closing brace } for the JSON snippet was accidentally removed, making the example syntactically incomplete. Let's restore it.

Suggested change
-> "result_uploaders": [ "dropbox" ]
}
-> "result_uploaders": [ "dropbox" ]
}

Comment thread docs/Image-Installation.md
Comment thread docs/Getting-Started.md Outdated
Comment thread docs/Getting-Started.md Outdated
Signed-off-by: rachael-george <rgeorge@redhat.com>
Comment thread docs/Getting-Started.md

- `qemu_bin` — QEMU system emulator.
- `qemu_img_bin` — `qemu-img` for disk image operations.
- `ivshmem_server_bin` — `ivshmem-server` when using a source QEMU build; leave `""` for distro packages.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is mandatory only for Ivshmem driver testing. Any ivshmem-server binary can be used

Comment thread docs/Getting-Started.md
- `qemu_bin` — QEMU system emulator.
- `qemu_img_bin` — `qemu-img` for disk image operations.
- `ivshmem_server_bin` — `ivshmem-server` when using a source QEMU build; leave `""` for distro packages.
- `fs_daemon_bin` — `virtiofsd` host file-sharing daemon.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is mandatory only for virtiofs driver testing. leave "" if you don't have virtiofsd and don't want to test virtiofs driver

Comment thread docs/Getting-Started.md
## Microsoft HLK playlists

To run HLK tests with the latest Microsoft compatibility playlist clone [HLK Playlists](https://github.com/HCK-CI/hlkplaylists) inside AutoHCK and rename the directory to playlists, once it's there AutoHCK will look for the right XML playlist file and apply it to the tests.
If you followed [step 5](#manual-installation), `playlists/` is already in place. Otherwise clone [HLK Playlists](https://github.com/HCK-CI/hlkplaylists) to `playlists/` at the AutoHCK repo root (path configured in `hcktest.json` → `playlists_path`). AutoHCK selects the appropriate XML playlist for the kit/platform.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kostyanf14

Copy link
Copy Markdown
Contributor

Please squash commits and force-push this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants