WIP: PG sequence bug repro + Postgres/MySQL CI matrix (#51)#52
Closed
ngan wants to merge 5 commits into
Closed
Conversation
Adds a `test_db` job covering rails_8.1 against postgresql and mysql2 with service containers, plus the infrastructure to make the dummy app's adapter configurable via `FIXTURE_KIT_DB`. Includes a failing integration spec that demonstrates the bug from issue #51: cached fixtures replay explicit-id INSERTs, but Postgres sequences don't advance, so a later `Model.create` collides at id=1. The spec passes on sqlite/mysql (their PK generators advance from explicit inserts) and fails on postgres. Fix to follow.
The job-level BUNDLE_GEMFILE was being inherited into the dummy app install step, causing bundler to look for gemfiles/rails_8.1.gemfile relative to spec/dummy and fail with ENOENT. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
ActiveRecordCoder#mount replays INSERTs that include explicit primary key values. Postgres sequences don't observe these inserts, so a later Model.create can call nextval and collide with an id we just inserted — intermittent PG::UniqueViolation in test runs that mount the cache onto a database whose sequence is at its initial value (e.g. parallel test workers with their own DB copies). Call reset_pk_sequence! per model after the batch executes. The method is only defined on the Postgres adapter, so the respond_to? guard makes this a no-op on MySQL and SQLite, whose AUTO_INCREMENT/INTEGER PK generators already advance from explicit-id INSERTs. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
- Group by connection_pool and wrap mount work in pool.with_connection, matching Rails' fixture insert flow. Behaviorally identical inside a test transaction, but more correct under role switching or programmatic use. - Prefer the batched reset_column_sequences! when the adapter exposes it (Rails 8.2+); fall back to per-table reset_pk_sequence! on 8.0/8.1. The batched path is unit-tested but won't have CI coverage until 8.2 ships and we add it to the appraisal matrix. - Skip virtual/generated columns when generating cached INSERTs. Without this, models with t.virtual columns crashed mount with "cannot INSERT into generated column". Adds a computed_widgets table with a stored generated column to the dummy app and a regression spec that exercises the round-trip. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
- Add verify_foreign_keys! mirroring Rails' fixture-loading pattern. Calls connection.check_all_foreign_keys_valid! when ActiveRecord.verify_foreign_keys_for_fixtures is true (default since Rails 8.0 load_defaults). PG and SQLite raise on violations; MySQL is a no-op. Wraps the StatementInvalid in a FixtureKit::Error with a hint that the cache may be stale relative to the schema. - Rename the execute_batch label from "FixtureKit Load" to "FixtureKit Insert" to match Rails' naming convention. - Harden the sql.active_record subscriber: use safe_constantize and require the result to be a Class < ActiveRecord::Base. Without this the renamed label feeds back into nested-fixture generates and crashes when constantize hits the FixtureKit module. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Collaborator
Author
|
Superseded by stacked PRs:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
test_dbCI job coveringrails_8.1× {postgresql, mysql2} with service containersFIXTURE_KIT_DBspec/integration/pk_sequence_repro_spec.rb— a failing test that reproduces Intermittent PG::UniqueViolation in tests when FixtureKit cache uses explicit PKs (PostgreSQL sequences not advanced) #51Expected CI state on this commit
AUTO_INCREMENTadvances on explicit-id INSERTs)PG::UniqueViolationatid=1The fix to
ActiveRecordCoder#mountwill land in a follow-up commit on this branch.Refs #51
🤖 Generated with Claude Code