test: add golden-file test to prevent accidental fixture removal - #56
Merged
knytcomics-ui merged 1 commit intoJul 20, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #35
Summary
This PR introduces a golden-file validation check to
scripts/validate-fixtures.mjsto prevent accidental removal or shrinkage of fixture sets (e.g. during a bad merge resolution).scripts/__fixtures__/expected-counts.json: Stores the minimum counts (total, clean, suspicious, malicious) and the explicit list of the 11 original seed fixture IDs.scripts/validate-fixtures.mjs: Readsexpected-counts.jsonand asserts that the current fixture state is at or above the expected minimums, and that all 11 original seed fixtures are present.Type of change
Changelog
Score-regression guard
Validation
npm run validatepasses locally.