Skip to content

test: add golden-file test to prevent accidental fixture removal - #56

Merged
knytcomics-ui merged 1 commit into
Gryd-lock:mainfrom
martinshub-tech:test/add-golden-file-fixtures
Jul 20, 2026
Merged

test: add golden-file test to prevent accidental fixture removal#56
knytcomics-ui merged 1 commit into
Gryd-lock:mainfrom
martinshub-tech:test/add-golden-file-fixtures

Conversation

@martinshub-tech

Copy link
Copy Markdown
Contributor

Closes #35

Summary

This PR introduces a golden-file validation check to scripts/validate-fixtures.mjs to prevent accidental removal or shrinkage of fixture sets (e.g. during a bad merge resolution).

  • Added scripts/__fixtures__/expected-counts.json: Stores the minimum counts (total, clean, suspicious, malicious) and the explicit list of the 11 original seed fixture IDs.
  • Modified scripts/validate-fixtures.mjs: Reads expected-counts.json and asserts that the current fixture state is at or above the expected minimums, and that all 11 original seed fixtures are present.

Type of change

  • Fixture change — adds, removes, or rescores a destination or asset
  • Transaction change — adds or removes a sample XDR
  • Documentation only — README, CONTRIBUTING, CHANGELOG prose, etc.
  • CI / tooling

Changelog

  • N/A — CI/tooling change only.

Score-regression guard

  • N/A — no scores were changed.

Validation

  • npm run validate passes locally.

@knytcomics-ui
knytcomics-ui merged commit 3aea4e9 into Gryd-lock:main Jul 20, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add golden-file tests asserting fixture counts and labels to catch accidental removal

2 participants