Skip to content

docs: write CONTRIBUTING.md with fixture labelling rubric and reviewe… - #55

Merged
knytcomics-ui merged 2 commits into
Gryd-lock:mainfrom
latiblack:docs/contributing-rubric
Jul 20, 2026
Merged

docs: write CONTRIBUTING.md with fixture labelling rubric and reviewe…#55
knytcomics-ui merged 2 commits into
Gryd-lock:mainfrom
latiblack:docs/contributing-rubric

Conversation

@latiblack

Copy link
Copy Markdown
Contributor

Closes #39

Rewrote CONTRIBUTING.md so new contributors don't have to reverse-engineer the existing fixtures to figure out what "suspicious" vs "malicious" actually means. The old one had the PR workflow and changelog format, but not the actual rubric.

What's new:

  • The labelling criteria with real examples from the 11 existing entries (clean, suspicious, malicious — each with what to look for and why)
  • A reviewer checklist so PRs don't bounce back and forth
  • Required fields table so nothing gets forgotten in fixture PRs
  • Cross-link from README

@latiblack

Copy link
Copy Markdown
Contributor Author

PR's up: https://github.com/latiblack/grydlock-testkit/pull/new/docs/contributing-rubric

Rewrote CONTRIBUTING.md with the actual labelling rubric generalized from the 11 existing fixtures, a reviewer checklist, and a required fields table. Also cross-linked from the README.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Write CONTRIBUTING.md with the fixture-labeling rubric and reviewer checklist

2 participants