Marshaling lap editor: prefilled lap time + Save, midpoint Split, Insert-after retired#373
Merged
Merged
Conversation
…, midpoint Split RD field feedback, third round tonight: - The time input opens PRE-FILLED with the selected lap's current time and 'Save time' arms only once the value changes — the RD reads, tweaks, saves. The new duration re-times the lap's closing pass (start + duration), so the correction is expressed in the unit RDs actually think in, never a free-typed absolute instant (which is what the input used to mean). - Split needs NO time: it halves the lap at its midpoint — the case is a missed gate crossing folding two real laps into one double-length lap, and the RD tunes either half with Save afterwards if the halves weren't even. - 'Insert after' is gone; the per-competitor '+ Add lap' footer covers insertion. - Remove vs Throw out spelled out in the tooltips: Remove = this crossing never really happened (noise/reflection; the pass is deleted and neighbouring laps merge); Throw out = the lap happened but doesn't count (course cut/penalty; stays on the clock, excluded from scoring). Remove edits reality; Throw out edits the score. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Per RD feedback: the editor now speaks lap times — the input opens prefilled with the selected lap's time and Save time arms only on change (re-timing the closing pass as start + new duration); Split halves the lap at its midpoint with no input (the missed-crossing case); Insert after is gone (+ Add lap covers it); and the Remove vs Throw out distinction is spelled out in the tooltips (crossing-never-happened vs lap-doesn't-count).
624 rd-console tests green, both svelte-checks clean, prettier/eslint clean.
🤖 Generated with Claude Code