chore(release): v0.3.1 and CI tag/version guardrail#27
Merged
Conversation
The v0.3.0 tag was placed on a commit that still had Cargo.toml at 0.2.3, so the updater shipped latest.json advertising 0.3.0 while the bundled binary reported 0.2.3 - every 0.2.3 client landed in an update loop because the "new" install reported the old version. Bump the workspace to 0.3.1 so installed_version == manifest_version once this tag ships, and add a CI step that fails the build whenever $GITHUB_REF_NAME disagrees with the workspace Cargo.toml version so the same mismatch can't ship again. Co-Authored-By: Claude
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
$GITHUB_REF_NAMEdisagrees with the workspaceCargo.tomlversion - prevents a repeat of the v0.3.0 mismatch.Background
The
v0.3.0tag landed on a commit that still declaredversion = "0.2.3"inCargo.toml(the version-bump commit lived on an unmerged source branch). Because.github/workflows/ci.ymlderives the updater manifest version from the git tag name (VERSION="${GITHUB_REF_NAME#v}"),latest.jsonadvertised0.3.0while the bundled binary still reported0.2.3from Cargo metadata. Every 0.2.3 client checked, saw 0.3.0, installed the same-version binary, restarted, still reported 0.2.3, looped forever.This PR fixes the symptom (ship a real 0.3.1 release whose binary genuinely reports 0.3.1) and the cause (CI now refuses to publish a release whose tag and Cargo.toml disagree).
Post-merge
v0.3.1on the merge commit and push to trigger the release pipeline.https://github.com/GregTheGreek/rompatch-rs/releases/latest/download/latest.jsonreports"version": "0.3.1".v0.3.0release + tag (separate cleanup, not part of this PR).Test plan
v0.3.1: CI's newverify tag matches Cargo.toml workspace versionstep passes.latest.jsonfrom the v0.3.1 release reports"version": "0.3.1".0.3.1, next check returnsnull(loop resolved).nullimmediately.v9.9.9-test) and confirm the new guardrail step fails CI; delete the tag after.