feat(gui): bottom-left update popup + CI platform-key fix (v0.2.2)#22
Merged
Conversation
UI: * Update notification moves from a top banner to a bottom-left floating card so it stays out of the way of the main panel content. * Two buttons: "Install now" (downloads + relaunches) and "Later" (hides the popup for this process lifetime; reappears next launch if an update is still available - the check only runs on mount). * Downloading and "installed - restarting" states reuse the same card shell. CI: * The latest.json manifest emitted by the gui job now includes darwin-aarch64 + darwin-x86_64 alongside darwin-universal. Tauri's updater matches the manifest's `platforms` map against the running process's target triple, not against "darwin-universal" alone, so the previous manifest silently missed on real Macs and check() returned null. v0.2.1's manifest had to be patched in place; this ensures future tags ship correct manifests out of the box. Version: 0.2.1 -> 0.2.2. Co-Authored-By: Claude
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two related changes shipped as v0.2.2:
UI - update popup
CI - latest.json platform keys
While testing v0.2.0 -> v0.2.1, the installed v0.2.0 app silently saw no update because the manifest only had
darwin-universal. Tauri's updater matchesplatformsagainst the running target triple (darwin-aarch64on Apple Silicon,darwin-x86_64on Intel) - the universal key alone does not satisfy that lookup, socheck()returned null. v0.2.1's manifest was hand-patched after the fact to confirm.This change emits all three platform keys (same .app.tar.gz + signature) so future tagged releases produce a manifest that real Macs can actually resolve.
Files
crates/rompatch-gui/ui/src/lib/updater.ts- adddismiss()crates/rompatch-gui/ui/src/components/UpdateBanner.tsx- bottom-left card layout.github/workflows/ci.yml- manifest now emits darwin-aarch64 + darwin-x86_64 + darwin-universalCargo.toml, the two explicitrompatch-corepins,ui/package.json,Cargo.lock)Test plan
cargo check --workspace --exclude rompatch-guicleanpnpm typecheck+pnpm buildcleanlatest.jsoncontains all three platform keys, confirm installed v0.2.1 sees the popup on next launch