Skip to content

reduce GC by skipping empty handlers in recipe handling #4909

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
GilbertzRivi wants to merge 2 commits into
base: 1.20.1
Choose a base branch
from
+6 −0
Open

reduce GC by skipping empty handlers in recipe handling #4909

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
efc2712
reduce GC by skipping empty handlers in recipe handling
GilbertzRivi Jun 5, 2026
99c3815
spotless
GilbertzRivi Jun 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/main/java/com/gregtechceu/gtceu/api/machine/trait/RecipeHandlerList.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -183,6 +183,9 @@ public Map<RecipeCapability<?>, List<Object>> handleRecipe(IO io, GTRecipe recip
var entry = it.next();
var handlerList = getCapability(entry.getKey());
for (var handler : handlerList) {
if (io == IO.IN && handler.getTotalContentAmount() == 0) {
continue;
}
var left = handler.handleRecipe(io, recipe, entry.getValue(), simulate);
if (left == null) {
it.remove();
Expand Down
3 changes: 3 additions & 0 deletions src/main/java/com/gregtechceu/gtceu/api/recipe/RecipeHelper.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -219,6 +219,9 @@ public static ActionResult handleRecipe(IRecipeCapabilityHolder holder, GTRecipe
Map<RecipeCapability<?>, List<Content>> contents,
Map<RecipeCapability<?>, Object2IntMap<?>> chanceCaches,
boolean isTick, boolean simulated) {
if (contents.isEmpty()) {
return ActionResult.PASS_NO_CONTENTS;
} ;

@htmlcsjs htmlcsjs Jun 5, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

potential typo with the random ; here?

@GilbertzRivi GilbertzRivi Jun 6, 2026

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ill fix at monday

RecipeRunner runner = new RecipeRunner(recipe, io, isTick, holder, chanceCaches, simulated);
var result = runner.handle(contents);

Expand Down
Loading