Small fixes and code QoL

[GregHib]

• Send all variables on login (so no longer have to write sendVariable's in playerSpawn {}'s)
• Fix concurrent floor item removal - temp see Replace floor item despawn system with lifecycle counter #994
• Add npc lifecycle and despawning system
• Close dialogues on opening quest journal
• Fix barrows overlay in resizable
• Fix fight cave logout

[github-actions]

Qodana for JVM

It seems all right 👌

No new problems were found according to the checks applied

💡 Qodana analysis was run in the pull request mode: only the changed files were checked
☁️ View the detailed Qodana report

Contact Qodana team

Contact us at qodana-support@jetbrains.com

• Or via our issue tracker: https://jb.gg/qodana-issue
• Or share your feedback: https://jb.gg/qodana-discussions

[codecov]

Codecov Report

❌ Patch coverage is 14.28571% with 60 lines in your changes missing coverage. Please review.
✅ Project coverage is 37.45%. Comparing base (b811abf) to head (c3297a8).

Files with missing lines	Patch %	Lines
...world/gregs/voidps/engine/client/update/NPCTask.kt	0.00%	23 Missing ⚠️
...s/voidps/engine/client/variable/PlayerVariables.kt	0.00%	6 Missing and 1 partial ⚠️
...ld/gregs/voidps/engine/entity/character/npc/NPC.kt	0.00%	6 Missing ⚠️
...d/gregs/voidps/engine/entity/character/npc/NPCs.kt	0.00%	6 Missing ⚠️
...me/src/main/kotlin/content/achievement/TaskList.kt	0.00%	3 Missing ⚠️
...me/src/main/kotlin/content/entity/combat/Target.kt	40.00%	2 Missing and 1 partial ⚠️
...t/quest/free/the_restless_ghost/SkeletonWarlock.kt	0.00%	3 Missing ⚠️
...egs/voidps/engine/client/variable/VariableStore.kt	0.00%	2 Missing ⚠️
...s/voidps/engine/entity/character/player/Players.kt	0.00%	1 Missing ⚠️
.../src/main/kotlin/content/achievement/TaskSystem.kt	0.00%	1 Missing ⚠️
... and 5 more

Additional details and impacted files

Files with missing lines	Coverage Δ
...d/gregs/voidps/engine/client/variable/Variables.kt	77.50% <ø> (ø)
...n/world/gregs/voidps/engine/data/AccountManager.kt	69.01% <100.00%> (+0.44%)	⬆️
.../gregs/voidps/engine/entity/character/Character.kt	12.20% <ø> (ø)
...ea/fremennik_province/lunar_isle/CaptainBentley.kt	9.52% <ø> (-7.87%)	⬇️
...rea/kharidian_desert/kalphite_lair/KalphiteHive.kt	20.00% <ø> (-18.47%)	⬇️
...ghold_of_player_safety/StrongholdOfPlayerSafety.kt	3.63% <ø> (-4.99%)	⬇️
...f_player_safety/StrongholdOfPlayerSafetyRewards.kt	6.89% <ø> (-6.01%)	⬇️
.../area/misthalin/lumbridge/church/GravestoneShop.kt	9.09% <ø> (+0.26%)	⬆️
...area/misthalin/lumbridge/church/LumbridgeChurch.kt	6.66% <ø> (-2.60%)	⬇️
...rea/misthalin/varrock/palace/VarrockPalaceDrain.kt	35.29% <ø> (+0.15%)	⬆️
... and 52 more

... and 2 files with indirect coverage changes

@@             Coverage Diff              @@
##               main     #995      +/-   ##
============================================
- Coverage     37.63%   37.45%   -0.18%     
+ Complexity     8245     8201      -44     
============================================
  Files          1696     1696              
  Lines         68641    68509     -132     
  Branches      17296    17294       -2     
============================================
- Hits          25834    25663     -171     
- Misses        36980    37019      +39     
  Partials       5827     5827              

Components	Coverage Δ
Content	35.38% <37.50%> (-0.25%)	⬇️
Engine	45.40% <2.17%> (-0.18%)	⬇️
Network	60.09% <ø> (ø)

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.