fix: declare GREEN_RELEASE as CACHE STRING so parent projects can pin dependency versions - #9
Merged
Merged
Conversation
… dependency versions Declare GREEN_RELEASE as a CACHE STRING so a parent FetchContent build's release version is inherited rather than shadowed by a local variable, removing declaration-order sensitivity when resolving transitive Green dependencies. Refs Green-Phys/green-mbpt#61 Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #9 +/- ##
=======================================
Coverage 98.46% 98.46%
=======================================
Files 3 3
Lines 130 130
=======================================
Hits 128 128
Misses 2 2 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the project’s CMake configuration so GREEN_RELEASE is defined as a CACHE STRING, allowing parent projects (e.g., via FetchContent or -DGREEN_RELEASE=...) to pin and propagate the desired Green dependency revision without being overridden by this project’s local set() order.
Changes:
- Declare
GREEN_RELEASEas aCACHE STRINGwith a descriptive cache help string. - Quote the default value (
origin/main) to make the intended string value explicit.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Declare
GREEN_RELEASEas aCACHE STRINGso a parent FetchContent build's release version is inherited rather than shadowed by a local variable, removing declaration-order sensitivity when resolving transitive Green dependencies.Refs Green-Phys/green-mbpt#61
🤖 Generated with Claude Code