fix cmake policy issue - #7
Conversation
There was a problem hiding this comment.
Pull request overview
This PR addresses CMake Policy issue #5 by updating the project’s CMake requirements and explicitly setting CMP0144 to control find_package(...) behavior.
Changes:
- Bump top-level
cmake_minimum_requiredfrom 3.18 to 3.27. - Set
cmake_policy(SET CMP0144 NEW)insrc/before callingfind_package(Eigen3 ...).
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| CMakeLists.txt | Raises the minimum supported CMake version to ensure newer policy behavior is available. |
| src/CMakeLists.txt | Explicitly sets CMP0144 to NEW before find_package(Eigen3 ...) in the src directory. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7 +/- ##
=======================================
Coverage 98.46% 98.46%
=======================================
Files 3 3
Lines 130 130
=======================================
Hits 128 128
Misses 2 2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Addresses Cmake Policy issue #5 by enforcing: