Skip to content

fix cmake policy issue - #7

Merged
gauravharsha merged 3 commits into
mainfrom
cmake
Feb 11, 2026
Merged

fix cmake policy issue#7
gauravharsha merged 3 commits into
mainfrom
cmake

Conversation

@gauravharsha

Copy link
Copy Markdown
Contributor

Addresses Cmake Policy issue #5 by enforcing:

  1. minimum version of 3.27
  2. explicitly setting cmake policy for find_package

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR addresses CMake Policy issue #5 by updating the project’s CMake requirements and explicitly setting CMP0144 to control find_package(...) behavior.

Changes:

  • Bump top-level cmake_minimum_required from 3.18 to 3.27.
  • Set cmake_policy(SET CMP0144 NEW) in src/ before calling find_package(Eigen3 ...).

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
CMakeLists.txt Raises the minimum supported CMake version to ensure newer policy behavior is available.
src/CMakeLists.txt Explicitly sets CMP0144 to NEW before find_package(Eigen3 ...) in the src directory.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread CMakeLists.txt
Comment thread src/CMakeLists.txt Outdated
@codecov

codecov Bot commented Feb 11, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.46%. Comparing base (7a33925) to head (4c4c51e).
⚠️ Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main       #7   +/-   ##
=======================================
  Coverage   98.46%   98.46%           
=======================================
  Files           3        3           
  Lines         130      130           
=======================================
  Hits          128      128           
  Misses          2        2           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@gauravharsha
gauravharsha merged commit 3a73f88 into main Feb 11, 2026
9 checks passed
@gauravharsha gauravharsha mentioned this pull request Feb 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants