fix: reset statistics timings after GW and HF kernels - #55
Merged
Conversation
Add statistics.reset() after printing timings in the GW and HF CPU kernels so per-iteration timing accumulators do not carry over. Also bump GREEN_RELEASE.txt to v1.0.0a1, pin macOS CI deps to origin/main during the tag window, and ignore .cache/ in git. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR aims to prevent per-iteration timing measurements from accumulating across iterations in the GW and HF CPU kernels, while also preparing the repository for the next pre-release and adjusting CI/ignore settings to keep builds working during the release transition.
Changes:
- Add
statistics.reset()after timing output in GW (gw_cpu_kernel.cpp) and HF (hf_cpu_kernels.cpp) CPU kernels. - Update
GREEN_RELEASE.txttov1.0.0a1for the next tag-driven pre-release. - Pin macOS CI builds to
-DGREEN_RELEASE=origin/mainand ignore.cache/via.gitignore.
Reviewed changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
src/hf_cpu_kernels.cpp |
Reset HF timing accumulators after printing, to avoid carry-over between iterations. |
src/gw_cpu_kernel.cpp |
Reset GW timing accumulators after printing, to avoid carry-over between iterations. |
GREEN_RELEASE.txt |
Bump release selector to v1.0.0a1 for the next pre-release tag. |
.gitignore |
Ignore .cache/* to avoid committing cache artifacts. |
.github/workflows/test_macos.yaml |
Force macOS CI dependency selection to origin/main via -DGREEN_RELEASE=origin/main. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Add the missing statistics.reset() after printing timings in the GF2 solver so per-iteration timing accumulators do not carry over. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
statistics.reset()after printing timings in the GW (gw_cpu_kernel.cpp) and HF (hf_cpu_kernels.cpp) CPU kernels, so per-iteration timing accumulators don't carry over between iterations.GREEN_RELEASE.txtfromv1.0.0a0tov1.0.0a1for the next tag-driven pre-release.origin/main(-DGREEN_RELEASE=origin/main) so the build keeps working whileGREEN_RELEASE.txtpoints at a tag before it's propagated to dependent repos..cache/in.gitignore.Notes
The version bump is bundled together with the timing fix in a single commit — no separate release-prep commit. The
green_tag.yamlworkflow will propagate the tag and resetGREEN_RELEASE.txtback toorigin/mainpost-release.🤖 Generated with Claude Code