Skip to content

replace context macro usage with inline function calls - #7

Merged
gauravharsha merged 1 commit into
mainfrom
fix/context-macro-conflict
May 14, 2026
Merged

replace context macro usage with inline function calls#7
gauravharsha merged 1 commit into
mainfrom
fix/context-macro-conflict

Conversation

@gauravharsha

Copy link
Copy Markdown
Contributor

Update all utils::context. call sites to utils::context(). following the replacement of the context preprocessor macro in green-utils with an inline function. Depends on Green-Phys/green-utils#5

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates green-ac to match the upstream change in green-utils where utils::context moved from a preprocessor macro to an inline function, requiring call sites to switch from utils::context.* to utils::context().*.

Changes:

  • Replaced most green::utils::context.* usages with green::utils::context().* in MPI/IO control flow.
  • Updated MPI communicator usage for broadcasts/allreduce to use context().global.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread main.cpp
@codecov-commenter

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (7ea2b14) to head (cbb0031).

Additional details and impacted files
@@            Coverage Diff            @@
##              main        #7   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            4         4           
  Lines          222       222           
=========================================
  Hits           222       222           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@egull egull left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the copilot comment is simply wrong, but please check.

@gauravharsha
gauravharsha merged commit 59929ab into main May 14, 2026
13 checks passed
@egull
egull deleted the fix/context-macro-conflict branch May 14, 2026 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants