Skip to content

fix: properly set the sky textures, only during the day #382

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JucanAndreiDaniel merged 1 commit into from
Jun 18, 2026
+15 −10
Merged

fix: properly set the sky textures, only during the day #382

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 15 additions & 10 deletions Assets/Gothic-Core/Scripts/Services/World/SkyService.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -144,21 +144,26 @@ private void UpdateStateTexAndFog()
Logger.LogError(e.ToString(), LogCat.Mesh);
return;
}

var fogColor = new Vector3(colorValues[0], colorValues[1], colorValues[2]);

foreach (var state in _stateList)
{
// all states that contain day sky layer dawn, evening and day 0 to 3
if (state.Time < 0.35 || state.Time > 0.65)
if (!(state.Time < 0.35) || !(state.Time > 0.65)) // set new textures only for day states

@JaXt0r JaXt0r Jun 18, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is time really a value from 0...1? I thought it's an int from 0...23 or so? Can you please check? 0.65 is tough to read instead of e.g. 8am.

@JaXt0r JaXt0r Jun 18, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And yes, it was there before, but maybe you find a nicer solution now. 😁

@JucanAndreiDaniel JucanAndreiDaniel Jun 18, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i want to handle this in a slightly bigger refactor, i don't like it either, this is just a quick fix for the modding weekend

{
continue;
}

state.Layer[0].TEXName = "SKYDAY_LAYER0_A" + day % 2 + ".TGA";

if (!(state.Time < 0.3) || !(state.Time > 0.7))
{
state.Layer[0].TEXName = "SKYDAY_LAYER0_A" + day % 2 + ".TGA";
// day states that contain sky cloud layer day 0 to 3
if (state.Time < 0.3 || state.Time > 0.7)
{
state.Layer[1].TEXName = "SKYDAY_LAYER1_A" + day % 2 + ".TGA";
state.FogColor = new Vector3(colorValues[0], colorValues[1], colorValues[2]);
state.DomeColor0 = new Vector3(colorValues[0], colorValues[1], colorValues[2]);
}
continue;
}

state.Layer[1].TEXName = "SKYDAY_LAYER1_A" + day % 2 + ".TGA";
state.FogColor = fogColor;
state.DomeColor0 = fogColor;
}
}

Expand Down