feat: move culled NPCs to their routine waypoint on schedule change#376
Open
BoroBongo wants to merge 5 commits into
Open
feat: move culled NPCs to their routine waypoint on schedule change#376BoroBongo wants to merge 5 commits into
BoroBongo wants to merge 5 commits into
Conversation
NpcRoutineService.CalculateCurrentRoutine now calls NotifyNpcRoutineChanged when the active routine slot changes, moving the culling sphere (and unloaded GO) to the new waypoint so off-screen NPCs progress their daily schedule. RecalculateAllNpcRoutines() iterates every NPC container and can be called after a time skip to synchronise all culled NPCs at once.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NpcRoutineService.CalculateCurrentRoutine now calls NotifyNpcRoutineChanged when the active routine slot changes, moving the culling sphere (and unloaded GO) to the new waypoint so off-screen NPCs progress their daily schedule. RecalculateAllNpcRoutines() iterates every NPC container and can be called after a time skip to synchronise all culled NPCs at once.
Summary
NpcMeshCullingDomainandNpcMeshCullingServicecoordinate withNpcRoutineServiceto apply the waypoint update without enabling the NPC's full GameObjectHow to test