feat: ZS_Dead equivalent — death XP and loot init on NPC kill#375
Open
BoroBongo wants to merge 7 commits into
Open
feat: ZS_Dead equivalent — death XP and loot init on NPC kill#375BoroBongo wants to merge 7 commits into
BoroBongo wants to merge 7 commits into
Conversation
FightService.OnNpcDied() now replicates Gothic's ZS_Dead AI state logic: 1. Resets AIV_PLUNDERED to 0 (FALSE) on the dead NPC's instance 2. If EnableDeathXP and the killer is the hero: calls B_DeathXP via the Daedalus VM (sets XP, level, LP), then syncs results to hero.Vob via NpcService.SyncHeroInstanceToVob() 3. Always calls B_GiveDeathInv so the loot panel has items to show 4. Restores GlobalSelf / GlobalOther after both VM calls EnableDeathXP is gated behind EnableCombatSystem in DeveloperConfig and marked WIP (damage values are still debug stubs). Also adds EnableLevel5Cheat and EnableGuildCheat flags in DeveloperConfig (Misc / WIP section) used by StatusMenu cheat triggers.
Contributor
Author
|
Tested and now after killing NPC you'll see a change in the status menu. Killed diego and got a lot of levels 🗡️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FightService.OnNpcDied() now replicates Gothic's ZS_Dead AI state logic:
Enable DeathXP is gated behind EnableCombatSystem in DeveloperConfig and marked WIP (damage values are still debug stubs).
Also adds EnableLevel5Cheat and EnableGuildCheat flags in DeveloperConfig (Misc / WIP section) used by StatusMenu cheat triggers.