Stack/03 animation playables#370
Merged
Merged
Conversation
JucanAndreiDaniel
force-pushed
the
stack/02-vob-loading
branch
from
5b8e619 to
c1eb815
Compare
Replaces the O(n) Queue.Contains() guard with a per-loader IsQueued flag, batch-drains the queue (10/frame) skipping destroyed entries, and clears pending entries on world change.
…onSkeleton Pose sampling/blending now runs as a Burst AnimationPoseJob over native arrays described by AnimationSkeleton, replacing the managed per-keyframe model.
…native samples AnimationTrack holds shared NativeArray pose buffers (with alias buffer sharing and InvertYAxis); AnimationTrackInstance is reduced to a lightweight playback cursor over them.
Bakes each track's positions/rotations once, pins root X/Z, stores root-Y as a rest-height offset, computes root-motion speed and flags sitting poses for Y inversion.
Schedules AnimationPoseJob through an AnimationScriptPlayable graph and applies baked root motion via RootCollisionHandler.
JucanAndreiDaniel
force-pushed
the
stack/03-animation-playables
branch
from
e28c5ce to
1189242
Compare
JucanAndreiDaniel
force-pushed
the
stack/03-animation-playables
branch
from
1189242 to
175c6f5
Compare
JaXt0r
approved these changes
Jun 14, 2026
JaXt0r
left a comment
JaXt0r
left a comment
Contributor
There was a problem hiding this comment.
Animations are working. Code looks good. I only got a few exceptions during play about Mobs and their usage. E.g., Diego is not sitting on his bench. But I don't expect it's related to the Animation rework.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Rewrites the NPC animation system onto Unity's
AnimationScriptPlayablewith a Burst pose job sampling baked native pose buffers, replacing the old managed keyframe model. This is the foundation for the AI/combat work in later PRs.Changes
AnimationKeyFrame; addsAnimationPoseJob(Burst sample+blend overNativeArraypose data) andAnimationSkeleton.AnimationTracknow owns shared native position/rotation buffers (with InvertYAxisflag for sitting poses);AnimationTrackInstance` is reduced to a playbackcursor.AnimationServicebakes each.manonce: pins root X/Z to zero, storeset, computes root-motion speed, and flags sitting poses.AnimationSystemschedules the pose job through anAnimationScriptPlayablegraph; root motion is applied viaRootCollisionHandler.AnimationSystemWindowToolupdated for the new pipeline.How to test
This is still not foolproof enough, there will still be issues, but the animation doesn't seem to be a bottleneck now on the quest