Skip to content

Stack/01 fixes standalone#368

Merged
JucanAndreiDaniel merged 5 commits into
mainfrom
stack/01-fixes-standalone
Jun 14, 2026
Merged

Stack/01 fixes standalone#368
JucanAndreiDaniel merged 5 commits into
mainfrom
stack/01-fixes-standalone

Conversation

@JucanAndreiDaniel

Copy link
Copy Markdown
Contributor

Summary

First in stack. Just some bugfixes for now.

Changes

  • Linux world path separatorsSaveGameService.ChangeWorld normalises \ to / before Path.GetFileName, which on Linux otherwise keeps the AddonWorld\ prefix and fails to match the loaded world.
  • ChangeLevel triggeroCTriggerChangeLevel box collider now has IsTrigger = 1 so level-change OnTriggerEnter actually fires.
  • Lockpick on unlocked containersVRContainerDoorPickingInteraction returns after deactivating itself, so it no longer starts the delayed coroutine on an already-unlocked container.
  • G2 cutscene suffix — corrected from CSL to LSC. Gothic 2 english steam version has OU.LSC

How to test

  • On Linux, change worlds (G2 portal to oldworld/addonworld) and confirm the target world tries to load (world traversal broken on current branch, should work on branch 04-culling).
  • Walk into a ChangeLevel trigger and confirm the level transition starts.
  • Interact with an already-unlocked container and confirm no lockpick minigame starts.

Path.GetFileName does not treat backslash as a separator on Linux, so G2 worlds like AddonWorld\NewWorld.zen kept their prefix. Normalise to forward slashes first.
The box collider must be a trigger for OnTriggerEnter level changes to fire.
Return after deactivating the handler so StartDelayed() is not started on an unlocked container.
@JucanAndreiDaniel JucanAndreiDaniel requested a review from JaXt0r June 13, 2026 13:04
@JucanAndreiDaniel JucanAndreiDaniel self-assigned this Jun 13, 2026
@JucanAndreiDaniel JucanAndreiDaniel added the bug Something isn't working label Jun 13, 2026

@JaXt0r JaXt0r left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Move on.

But there is no change with regards to lock picking as mentioned in the PR description:

Lockpick on unlocked containers — VRContainerDoorPickingInteraction returns after deactivating itself, so it no longer starts the delayed coroutine on an already-unlocked container.

@JucanAndreiDaniel

Copy link
Copy Markdown
Contributor Author

probably the change was already in main, and as you merged main into this branch, it disappeared
commit is still there - 76c6c02

@JucanAndreiDaniel JucanAndreiDaniel merged commit 06ce37d into main Jun 14, 2026
@JucanAndreiDaniel JucanAndreiDaniel deleted the stack/01-fixes-standalone branch June 14, 2026 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants