Skip to content

Document gke-deploy timeout overrides#1109

Open
Haihan-Jiang wants to merge 1 commit into
GoogleCloudPlatform:masterfrom
Haihan-Jiang:codex/gke-deploy-timeout-docs
Open

Document gke-deploy timeout overrides#1109
Haihan-Jiang wants to merge 1 commit into
GoogleCloudPlatform:masterfrom
Haihan-Jiang:codex/gke-deploy-timeout-docs

Conversation

@Haihan-Jiang
Copy link
Copy Markdown

Description

Documents how to extend the wait used by gke-deploy apply in Cloud Build.

The examples now expose _GKE_DEPLOY_TIMEOUT for the apply step, and the Cloud Build guide explains the difference between:

  • gke-deploy --timeout, which controls how long gke-deploy waits for Kubernetes objects to become ready
  • Cloud Build step timeout, which controls how long Cloud Build lets the whole step run

I also corrected the cloudbuild-with-configs.yaml submit example to pass _OUTPUT_BUCKET_PATH, which is the substitution used by that sample config.

Validation

  • git diff --check
  • Parsed both sample Cloud Build YAML files with Ruby YAML.load_file
  • Checked relative Markdown links in deploying-with-cloud-build.md
  • go test ./cmd/...
  • go test ./deployer/...

Updates the docs for #1031.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant