Document gke-deploy timeout overrides#1109
Open
Haihan-Jiang wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Documents how to extend the wait used by
gke-deploy applyin Cloud Build.The examples now expose
_GKE_DEPLOY_TIMEOUTfor the apply step, and the Cloud Build guide explains the difference between:gke-deploy --timeout, which controls how longgke-deploywaits for Kubernetes objects to become readytimeout, which controls how long Cloud Build lets the whole step runI also corrected the
cloudbuild-with-configs.yamlsubmit example to pass_OUTPUT_BUCKET_PATH, which is the substitution used by that sample config.Validation
git diff --checkYAML.load_filedeploying-with-cloud-build.mdgo test ./cmd/...go test ./deployer/...Updates the docs for #1031.