Handle manual form submissions in evals-cli#305
Open
swissspidy wants to merge 4 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #66
When WebMCP forms do not use the
toolautosubmitattribute, the browser activates the form and fires atoolactivatedDOM event rather than automatically submitting. In a headlessevals-clisession, this previously caused the browser evaluation to hang indefinitely.This PR addresses the issue by handling
toolactivatedevents gracefully, adding tool execution result verification to evals, and reflecting result comparisons in both the console and HTML reports.Changes
Graceful
toolactivatedHandling inBrowserToolRegistry:toolactivatedDOM event when executing browser tools.toolactivatedfires, resolves the tool execution with"pending form submission".listToolsFromPagefunction.Tool Execution Result Matching (
resultinexpectedCall):result?: unknown;field toFunctionCallandToolCalltypes.VercelBackendto capture the tool execution return value on each executedToolCall.functionCallOutcomeinutils.tsto evaluateexpected.resultagainstactual.resultusingmatchesArgument(supports exact match, objects, regex$pattern,$contains, etc.).Report and Console Enhancements:
Example Evals for French Bistro Demo:
evals.jsonto assert"result": "pending form submission"when testing manual form submission behavior.evals-toolautosubmit.jsonto assert"result": { "$contains": "welcoming you" }when testing auto-submission behavior.Examples
Expecting manual form submission:
Expected auto form submission:
Expecting manual form submission on a form with
toolautosubmitresults in an error:Expecting auto form submission ohn a form without
toolautosubmitresults in an error: