fix: Dynamically decide QR code box background/fill colors#2480
Merged
Conversation
The current QR codes surprisingly can't be scanned by Pixel phones (but works on iPhones surprisingly) due to the corner boxes (which the camera uses for alignment when scanning QR codes) not being present. And the boxes aren't present because of currently inverted values for the QR code's fill/background values. This change makes it so the website correctly decides the fill/background color for the QR code depending on whether the user is in light/dark mode. And as a result, the corner boxes are always present.
jrobbins
approved these changes
May 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current QR codes surprisingly can't be scanned by Pixel phones (but works on iPhones surprisingly) due to the corner boxes (which the camera uses for alignment when scanning QR codes) not being present. And the boxes aren't present because of currently inverted values for the QR code's fill/background values.
This change makes it so the website correctly decides the fill/background color for the QR code depending on whether the user is in light/dark mode. And as a result, the corner boxes are always present.
Before (where light mode does NOT work on Pixels but dark mode DOES):
After (light mode changed, dark mode stays the same):
