Skip to content

Refactor duplicated error class definitions in task-runner #124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Copilot wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

Refactor duplicated error class definitions in task-runner #124

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d914504
Initial plan
Copilot Feb 5, 2026
1b6400d
Initial analysis of duplicated code
Copilot Feb 5, 2026
f2e2ad4
Refactor duplicated error class definitions in validators.js
Copilot Feb 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
52 changes: 36 additions & 16 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

44 changes: 20 additions & 24 deletions packages/jsdoc-task-runner/lib/validators.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,23 @@ function checkTask(t) {
};
}

// Factory function to create simple error classes with message validation
function createErrorClass(name) {
const ErrorClass = class extends Error {
constructor(message) {
ow(message, ow.string);
super(message);

this.name = name;
}
};

// Set the class name for proper error identification
Object.defineProperty(ErrorClass, 'name', { value: name });

return ErrorClass;
}

export default {
checkTaskOrString: ow.any(ow.object.validate(checkTask), ow.string),
DependencyCycleError: class DependencyCycleError extends Error {
Expand All @@ -36,28 +53,7 @@ export default {
this.name = 'DependencyCycleError';
}
},
StateError: class StateError extends Error {
constructor(message) {
ow(message, ow.string);
super(message);

this.name = 'StateError';
}
},
UnknownDependencyError: class UnknownDependencyError extends Error {
constructor(message) {
ow(message, ow.string);
super(message);

this.name = 'UnknownDependencyError';
}
},
UnknownTaskError: class UnknownTaskError extends Error {
constructor(message) {
ow(message, ow.string);
super(message);

this.name = 'UnknownTaskError';
}
},
StateError: createErrorClass('StateError'),
UnknownDependencyError: createErrorClass('UnknownDependencyError'),
UnknownTaskError: createErrorClass('UnknownTaskError'),
};
Loading