changed the merge from using mkvmerge to using ffmpeg#118
Open
elisha464 wants to merge 1 commit into
Open
Conversation
when merge the subtitles with the video mkvmerge was sometimes throwing warnings, and when it throws a warning the exit code of the program is 1 and that throws an error eventhough the merge is totally ok I switched the merge to use ffmpeg, it feels much more suited for the job and it also removes the dependency on another executable
|
Code Climate has analyzed commit a45f12b and detected 0 issues on this pull request. View more on Code Climate. |
Owner
|
The merge is not OK. Some episodes have incorrect subtitles, and they need to be corrected. Yes mkvmerge return with an error value for a warning; but the subtitles are really incorrect. There is an open issue about that: #65, and instead of using a tool which does not warn/errored on invalid subtitles (some of the entries are beyond the length of the video) I would prefer to have a way to detect them and patch the file on the fly. |
Author
|
are you sure that the problem is because of the subtitles? and if so what kind of fix did you have in mind? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
when merging the subtitles with the video mkvmerge was sometimes throwing warnings, and when it throws a warning the exit code of the program is 1 and that throws an error even though the merge is totally OK
I switched the merge to use ffmpeg, it feels much more suited for the job and it also removes the dependency on another executable
Checklist
[X] I've run
npm run compileand it produce no error[X] I've run
npm run testand it produce no error[X] I've not pushing more than one feature in that pull request
[X] My branch is updated with the latest from main when I make that pull request
[X] I've tested as much as I can my changes