Более коректная обработка анимации спиннера - #27
Open
serega404 wants to merge 3 commits into
Open
Conversation
Update show_spinner to wait for the target background job with wait "$pid" instead of polling the PID. Run the spinner animation in its own background process, stop and terminate it after the target job exits, preserve the target exit code, and keep the existing output format.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
1 Добавил экранирование (только в этот модуль)
2 Раньше спиннер пытался сам понять, жив ли процесс, проверяя PID. Это могло зависнуть или работать по-разному на разных системах (другой PR сообщающий от этой проблеме). Теперь спиннер крутится отдельно, пока shell ждёт основную команду через wait "$pid". Когда команда завершается, мы получаем её exit code и после чего останавливаем спиннер.
Протестировано на: