feat(catalog-etl): wrap shouldSkip() in outer try/catch to prevent unhandled cron errors#291
Open
GitAddRemote wants to merge 1 commit into
Open
feat(catalog-etl): wrap shouldSkip() in outer try/catch to prevent unhandled cron errors#291GitAddRemote wants to merge 1 commit into
GitAddRemote wants to merge 1 commit into
Conversation
…ent unhandled cron errors - Enclose the full scheduledTerminalEtl() body in an outer try/catch so any DB error thrown by getLastSuccessfulStepRun() is caught, logged at ERROR, and returned rather than propagating as an unhandled scheduler exception - Inner try/catch blocks for runStep() calls remain unchanged — their error handling is unaffected - Add test: guard-throws path resolves without throwing and logs 'terminal ETL skip guard failed' Closes #227
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
scheduledTerminalEtl()body is now wrapped in an outertry/catchso anygetLastSuccessfulStepRun()DB error thrown byshouldSkip()is caught and logged atERRORlevel rather than escaping the cron handler as an unhandled rejectiontry/catchblocks forrunStep()calls are unchanged — their error-handling paths are unaffected'terminal ETL skip guard failed'and return cleanly without crashing the schedulerNote: This PR targets
feature/ISSUE-221(notmain) since it builds on the consolidated scheduler introduced there.Test plan
getLastSuccessfulStepRunrejects → method resolves without throwing,logger.errorcalled with'terminal ETL skip guard failed',runStepnot calledCloses #227