Skip to content

Add confirmation prompt for removing a member from the band#714

Open
PresidentNick wants to merge 2 commits into
Gig-o-Matic:mainfrom
PresidentNick:686-remove-member-confirm
Open

Add confirmation prompt for removing a member from the band#714
PresidentNick wants to merge 2 commits into
Gig-o-Matic:mainfrom
PresidentNick:686-remove-member-confirm

Conversation

@PresidentNick

Copy link
Copy Markdown
Contributor

resolves #686

@aaronoppenheimer

Copy link
Copy Markdown
Contributor

A great thing to implement - thanks. Two things:

  1. The translations don't work because of the 'fuzzy' comments in the po file. Looking at the po files, there are a lot of fuzzies in there - but we can't just strip them out without checking to make sure the translations are still right (since the message compiler might have done something weird). I'll add an issue to do this, but for now you can do it on your new strings.
  2. Instead of using the htmx-confirm dialog you should use the bootbox one like when trashing or archiving a gig - see here. I'm aware that we also use a javascript file static/js/bootstrap-show-modal. This should be cleaned up! But let's not add a third one.

thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove From Band needs confirmation step

2 participants