Add CallType.AudioRoom for the audio_room server call type#1685
Conversation
PR checklist ✅All required conditions are satisfied:
🎉 Great job! This PR is ready for review. |
WalkthroughThis PR introduces a new ChangesAudioRoom Call Type Addition
🎯 2 (Simple) | ⏱️ ~8 minutes
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
SDK Size Comparison 📏
|
Adds CallType.AudioRoom (name = "audio_room") to mirror the same-named call
type used by React and iOS. Overrides sortPreset to LivestreamOrAudioRoom so
group audio chats self-sort with role-aware ordering out of the box.
Distinct from CallType.AudioCall (Android-specific 1:1 voice call). AudioCall
keeps SortPreset.Default — role-based sort doesn't apply to a two-participant
call.
Updates CallType.fromName to include AudioRoom in the lookup list.
Tests: extends CallTypeSortPresetTest with assertions for AudioRoom.sortPreset
and the fromName("audio_room") resolution path.
apiCheck vs develop: additive only.
|
✅ Actions performedReview triggered.
|
be12147 to
f7461e6
Compare
|
CallType.AudioRoom for the audio_room server call type
|
🚀 Available in v1.24.0 |



Goal
Adds
CallType.AudioRoomfor the"audio_room"server call type used by React and iOS, completing the cross-platform call-type parity left open by #1684.Implementation
CallType.AudioRoom : CallType("audio_room")— new singleton.sortPresettoSortPreset.LivestreamOrAudioRoomso group audio rooms self-sort with role-aware ordering, matching React (CallType.ts:120-122) and iOS (LivestreamPlayer.swift:103,129).CallType.fromNamelookup list updated to includeAudioRoom.CallType.AudioCall, which is the Android-specific 1:1 voice call type.AudioCallkeepsSortPreset.Default— role-based sort doesn't make sense for a two-participant call.apiCheckvsdevelop: additive only.Testing
Manually: create an
"audio_room"call type on the server, join it from the dogfood app, confirm participants sort by activity + role without any UI configuration.Depends on
#1684 — provides
SortPreset.LivestreamOrAudioRoomand theCallType.sortPresetplumbing.Summary by CodeRabbit
New Features
Tests