Fix embedded group selection when multiple groups share the same name#5
Open
Geojim wants to merge 3 commits into
Open
Fix embedded group selection when multiple groups share the same name#5Geojim wants to merge 3 commits into
Geojim wants to merge 3 commits into
Conversation
When embedding a group from another project, the dialog returned only group names which were then resolved via findGroup() - a depth-first search returning the first match. When multiple groups shared the same name, the wrong group could be embedded. Fix by introducing path-based group identification: selectedGroupPaths() returns the full tree path (chain of ancestor names with occurrence indices) for each selected group. A new findGroupByPath() navigates the tree using this path, skipping embedded groups, to find the exact group the user selected. A corresponding createEmbeddedGroup() overload accepts this path for unambiguous group resolution. https://claude.ai/code/session_01JUB2eYmtWFLUyCHis7dgpz
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When embedding a group from another project, the dialog returned only
group names which were then resolved via findGroup() - a depth-first
search returning the first match. When multiple groups shared the same
name, the wrong group could be embedded.
Fix by introducing path-based group identification: selectedGroupPaths()
returns the full tree path (chain of ancestor names with occurrence
indices) for each selected group. A new findGroupByPath() navigates
the tree using this path, skipping embedded groups, to find the exact
group the user selected. A corresponding createEmbeddedGroup() overload
accepts this path for unambiguous group resolution.
https://claude.ai/code/session_01JUB2eYmtWFLUyCHis7dgpz