Skip to content

[Fixes #14248] Fix proxy registry initialization#14249

Merged
giohappy merged 3 commits into
masterfrom
ISSUE_14248
May 27, 2026
Merged

[Fixes #14248] Fix proxy registry initialization#14249
giohappy merged 3 commits into
masterfrom
ISSUE_14248

Conversation

@sijandh35
Copy link
Copy Markdown
Contributor

Fixes #14248

Checklist

Reviewing is a process done by project maintainers, mostly on a volunteer basis. We try to keep the overhead as small as possible and appreciate if you help us to do so by completing the following items. Feel free to ask in a comment if you have troubles with any of them.

For all pull requests:

  • Confirm you have read the contribution guidelines
  • You have sent a Contribution Licence Agreement (CLA) as necessary (not required for small changes, e.g., fixing typos in the documentation)
  • Make sure the first PR targets the master branch, eventual backports will be managed later. This can be ignored if the PR is fixing an issue that only happens in a specific branch, but not in newer ones.

The following are required only for core and extension modules (they are welcomed, but not required, for contrib modules):

  • There is a ticket in https://github.com/GeoNode/geonode/issues describing the issue/improvement/feature (a notable exemption is, changes not visible to end-users)
  • The issue connected to the PR must have Labels and Milestone assigned
  • PR for bug fixes and small new features are presented as a single commit
  • PR title must be in the form "[Fixes #<issue_number>] Title of the PR"
  • New unit tests have been added covering the changes, unless there is an explanation on why the tests are not necessary/implemented

Submitting the PR does not require you to check all items, but by the time it gets merged, they should be either satisfied or inapplicable.

@cla-bot cla-bot Bot added the cla-signed CLA Bot: community license agreement signed label May 22, 2026
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors the ProxyUrlsRegistry in geonode/proxy/utils.py to use a property-based lazy initialization and periodic reload mechanism, accompanied by a new unit test in geonode/proxy/tests.py. The review identifies a critical infinite recursion bug in the getter logic when the reload threshold is met, suggests updating the reload timestamp within the setter to ensure consistent state tracking, and recommends implementing thread-safety measures to prevent race conditions during the initialization process.

Comment thread geonode/proxy/utils.py Outdated
Comment thread geonode/proxy/utils.py
Comment thread geonode/proxy/utils.py
@codecov
Copy link
Copy Markdown

codecov Bot commented May 22, 2026

Codecov Report

❌ Patch coverage is 94.59459% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 74.94%. Comparing base (91c4ec5) to head (04adaf3).
⚠️ Report is 13 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #14249      +/-   ##
==========================================
+ Coverage   74.92%   74.94%   +0.02%     
==========================================
  Files         975      975              
  Lines       59902    59963      +61     
  Branches     8157     8166       +9     
==========================================
+ Hits        44884    44942      +58     
- Misses      13194    13197       +3     
  Partials     1824     1824              
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Comment thread geonode/proxy/utils.py
@giohappy giohappy merged commit ac65364 into master May 27, 2026
19 checks passed
@giohappy giohappy deleted the ISSUE_14248 branch May 27, 2026 11:10
@github-actions
Copy link
Copy Markdown
Contributor

The backport to 5.1.x failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-5.1.x 5.1.x
# Navigate to the new working tree
cd .worktrees/backport-5.1.x
# Create a new branch
git switch --create backport-14249-to-5.1.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 ac6536405cec392781a0fcbd6a734e2cf676f41b
# Push it to GitHub
git push --set-upstream origin backport-14249-to-5.1.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-5.1.x

Then, create a pull request where the base branch is 5.1.x and the compare/head branch is backport-14249-to-5.1.x.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport 5.1.x cla-signed CLA Bot: community license agreement signed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix proxy registry initialization

3 participants