[Bug] Fix memory profiler number formatting - #818
Draft
btgaskin wants to merge 1 commit into
Draft
Conversation
Collaborator
|
Hi, I notice this is marked 'draft'. Is that intentional? If so, I'll wait till it is in 'ready for review' before proceeding further. |
Collaborator
|
(notably, I cannot run |
|
To use Codex here, create a Codex account and connect to github. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates the memory profiler's locale-aware integer formatting for bundled fmt 10 and exercises the sparse-tree output paths in a CPU regression test.
Originally reported in taichi-dev/taichi#8663.
This fixes profiler output only; it does not change allocator lifetimes.
Checks: editable build; memory-profiler test (1 passed); pre-commit.