Add a helm plugin - #23
Merged
Merged
Conversation
helm is consumed by the infra repo (chart linting, templating and publishing) but has no proto descriptor, so it is installed out of band and its version floats. Binaries come from get.helm.sh rather than the GitHub release assets, and each archive nests the binary under an <os>-<arch>/ directory, hence the archive-prefix.
tanguylebarzic
marked this pull request as ready for review
August 3, 2026 15:11
jlouazel
approved these changes
Aug 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a
helmTOML plugin, plus its README and.prototoolspin (4.2.3, current latest), similarly to other plugins like kubeconform.helm is used by the infra repo for chart linting, templating and publishing (
influx chart validateshells out tohelm lint/helm template), but it has no descriptor here. Today it is installed out of band: CI usesazure/setup-helm@v5with the defaultversion: latest, so chart validation silently follows whatever helm ships, and on a host outside the devcontainer helm is simply absent. Follow-up in infra: https://github.com/Genesis-Embodied-AI/infra/pull/1199Two things differ from most plugins here and explain the descriptor's shape:
download-url/checksum-urldo not followgit-url.<os>-<arch>/directory, so each platform setsarchive-prefix.The
version-patternanchors on bare semver because helm tags release candidates (v4.0.0-rc.1), which would otherwise winlatest --resolve.Test plan
proto install helmon macOS arm64: downloads, verifies the sha256sum, unpacks./scripts/smoke-test.shreportsok helm(other tools FAIL only because they are not installed locally at this repo's pins; CI installs them first)proto run helm -- versionreportsv4.2.3proto run prek -- run --all-filespasses (taplo format + lint, typos, file hygiene)