Align Caller/Callee roles with TCP connection roles#46
Merged
Conversation
The Caller now acts as TCP client (connects, sends offer). The Callee now acts as TCP server (listens, answers offer). This aligns WebRTC semantics with transport semantics, eliminating confusion in BasicVideoChat where roles were previously inverted. Changes: - Flip UI IP enable/disable logic (Caller: enabled, Callee: disabled) - Swap TCP calls: Caller uses ConnectAsync, Callee uses ListenAsync - Update status messages to reflect actual TCP operations - Clarify TcpSignalingChannel comments with correct role mapping - Update CONTEXT.md glossary with Host/role distinction notes Documented in ADR-0002: Caller and Callee roles align with TCP connection roles. Fixes #45
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Caller now acts as TCP client (connects, sends offer). Callee now acts as TCP server (listens, answers offer).
This aligns WebRTC semantics with transport semantics, fixing the inverted role mapping in BasicVideoChat.
Why
The previous mapping confused the example:
This design decision is documented in ADR-0002.
Changes
Fixes #45