Skip to content

fix(website): replace isStaging conditionals with byEnv in RSV-A/B wastewater config#1290

Open
fhennig wants to merge 1 commit into
mainfrom
fix/wastewater-rsv-byenv-conditionals
Open

fix(website): replace isStaging conditionals with byEnv in RSV-A/B wastewater config#1290
fhennig wants to merge 1 commit into
mainfrom
fix/wastewater-rsv-byenv-conditionals

Conversation

@fhennig

@fhennig fhennig commented Jun 25, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Replaces leftover isStaging ? X : Y conditionals in wastewaterConfig.ts that were introduced as a rebase artifact
  • Converts them to byEnv(env, { prod, staging, local }) calls consistent with the rest of the file
  • Affects collectionsUserId (RSV-A, RSV-B) and variant filter collectionId (RSV-A: local=21, RSV-B: local=74)

Test plan

  • TypeScript build passes without Cannot find name 'isStaging' errors
  • RSV-A and RSV-B wastewater pages load correctly on staging and production

🤖 Generated with Claude Code

…stewater config

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@vercel

vercel Bot commented Jun 25, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
dashboards Ready Ready Preview, Comment Jun 25, 2026 2:02pm

Request Review

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes a rebase artifact in the website’s wastewater configuration by replacing leftover isStaging ? X : Y conditionals (which were not in scope / not defined in this file) with the existing byEnv(env, { prod, staging, local }) helper pattern already used elsewhere in wastewaterConfig.ts.

Changes:

  • Replaced isStaging ternaries with byEnv(...) for RSV-A/RSV-B predefinedVariantsSource.collectionsUserId.
  • Replaced isStaging ternaries with byEnv(...) for RSV-A/RSV-B variant filter collectionId, adding explicit local IDs (RSV-A: 21, RSV-B: 74).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants