fix(website): replace isStaging conditionals with byEnv in RSV-A/B wastewater config#1290
Open
fhennig wants to merge 1 commit into
Open
fix(website): replace isStaging conditionals with byEnv in RSV-A/B wastewater config#1290fhennig wants to merge 1 commit into
fhennig wants to merge 1 commit into
Conversation
…stewater config Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a rebase artifact in the website’s wastewater configuration by replacing leftover isStaging ? X : Y conditionals (which were not in scope / not defined in this file) with the existing byEnv(env, { prod, staging, local }) helper pattern already used elsewhere in wastewaterConfig.ts.
Changes:
- Replaced
isStagingternaries withbyEnv(...)for RSV-A/RSV-BpredefinedVariantsSource.collectionsUserId. - Replaced
isStagingternaries withbyEnv(...)for RSV-A/RSV-B variant filtercollectionId, adding explicitlocalIDs (RSV-A: 21, RSV-B: 74).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
fengelniederhammer
approved these changes
Jun 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
isStaging ? X : Yconditionals inwastewaterConfig.tsthat were introduced as a rebase artifactbyEnv(env, { prod, staging, local })calls consistent with the rest of the filecollectionsUserId(RSV-A, RSV-B) and variant filtercollectionId(RSV-A: local=21, RSV-B: local=74)Test plan
Cannot find name 'isStaging'errors🤖 Generated with Claude Code