-
Notifications
You must be signed in to change notification settings - Fork 0
feat(website): introduce DB_ID_SPACE env var for environment-specific collection IDs #1278
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
e3f23c8
feat(website): introduce DB_ID_SPACE env var for environment-specific…
fhennig 1fe3dbe
refactor(website): change byEnv to use named-object params instead of…
fhennig d3404aa
fix(website): use correct local collection ID for COVID variant filte…
fhennig 46168f6
fix(e2e): set DB_ID_SPACE=local in website Docker container for E2E t…
fhennig 92fa19f
refactor(website): use DbIdSpace type in env.d.ts instead of inlining…
fhennig 993f787
refactor(website): derive DB_ID_SPACE from DASHBOARDS_ENVIRONMENT by …
fhennig 67de716
review
fhennig File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,5 @@ | ||
| CONFIG_DIR=../backend/src/main/resources/ | ||
| DASHBOARDS_ENVIRONMENT=dashboards-prod | ||
| DB_ID_SPACE=local | ||
|
|
||
| AUTH_SECRET="e2e-test-auth-secret-do-not-use-in-production" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,22 @@ | ||
| export const dbIdSpaces = { | ||
| prod: 'prod', | ||
| staging: 'staging', | ||
| local: 'local', | ||
| } as const; | ||
|
|
||
| export type DbIdSpace = (typeof dbIdSpaces)[keyof typeof dbIdSpaces]; | ||
|
|
||
| export function getDbIdSpace(): DbIdSpace { | ||
| const envValue = process.env.DB_ID_SPACE ?? import.meta.env.DB_ID_SPACE; | ||
| if (envValue) { | ||
| const validValues: string[] = [dbIdSpaces.prod, dbIdSpaces.staging, dbIdSpaces.local]; | ||
| if (validValues.includes(envValue)) { | ||
| return envValue as DbIdSpace; | ||
| } | ||
| throw new Error( | ||
| `Environment variable DB_ID_SPACE (value '${envValue}') is not valid. Expected one of: ${validValues.join(', ')}`, | ||
| ); | ||
| } | ||
| const dashboardsEnv = process.env.DASHBOARDS_ENVIRONMENT ?? import.meta.env.DASHBOARDS_ENVIRONMENT; | ||
| return dashboardsEnv === 'dashboards-staging' ? dbIdSpaces.staging : dbIdSpaces.prod; | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.