Skip to content

Http client now stores whole response #26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Ikera wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Http client now stores whole response #26

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions lib/rapidash/http_client.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@

module Rapidash
module HTTPClient
attr_accessor :login, :password, :request_default_options
attr_accessor :login, :password, :request_default_options, :response
attr_writer :connection

# Provide login and password fields for basic HTTP authentication
Expand Down Expand Up @@ -32,9 +32,9 @@ def connection
def request(verb, url, options = {})
options.merge!(self.request_default_options) if self.request_default_options
url = connection.build_url(normalize_url(url), options[:params]).to_s
response = connection.run_request(verb, url, options[:body], options[:header])
self.response = connection.run_request(verb, url, options[:body], options[:header])

response.body
self.response.body
end
end
end
7 changes: 7 additions & 0 deletions spec/rapidash/http_client_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,6 +67,13 @@ def self.raise_error
subject.request(:get, "foo")
end

it "should store response" do
response = double(:body => "response")
allow(subject.connection).to receive(:run_request).with(:get, "http://example.com/foo", nil, nil).and_return(response)
subject.request(:get, "foo")
expect(subject.response).to eq(response)
end

describe "default options" do
let!(:subject) { HTTPTester.new(request_default_options: { header: { user_agent: 'New app v1.0'} } ) }

Expand Down