Garyfallidis new api dti#6
Open
arokem wants to merge 48 commits into
Open
Conversation
RF - remove some old functions tools
Added a dependency on basemap.
This required changes in many testing functions that rely on this function.
BF: Fixed projection plots.
remove _filter_peaks
RF - fixup peaks_from_model to take use remove_similar_vertices and
Add fast ndindex.
RF - Provide shape as argument to ndindex.
A simpler ndindex using generators.
DOC: Fixed some typos, etc in the FAQ
NF - wrapper function for multi voxel models
Note that we implement Tensor for backwards compatibility.
This means that going forward TensorModel and TensorFit do not support indexing.
Also: added a deprecation warning to the old implementation.
Garyfallidis
pushed a commit
that referenced
this pull request
Mar 5, 2014
pep8 for cc.pyx and em.pyx
Garyfallidis
pushed a commit
that referenced
this pull request
Mar 7, 2017
Updated conflicted files with master
Garyfallidis
added a commit
that referenced
this pull request
Oct 14, 2017
VIZ: A lightweight UI for medical visualizations #6: 2D File Selector
Garyfallidis
pushed a commit
that referenced
this pull request
Dec 16, 2021
`get_pmf_value`, fix compiling issue
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is along the lines of what we discussed on dipy#78
I opted to leave a lot of the old implementation, with a deprecation warning, so that we can pull this all out in a subsequent release.
If these changes are agreeable to everyone, @Garyfallidis: you could pull this into your branch and then we can then merge that pull request into nipy/dipy master branch.
The next step once we are happy with this is then for me to rebase my RESTORE branch on top of these changes (and handle whatever conflicts may arise). Then, we can work to get that merged as well. @MrBago, you mentioned that you had some ideas on how to speed that up. Maybe we could meet sometime after SfN to look at that? I am back on the 18th.