Skip to content

Adds Sphere Object to sphere function in viz.actors#56

Open
thechargedneutron wants to merge 61 commits into
Garyfallidis:cancer_spheresfrom
thechargedneutron:cancer_spheres_mod_version
Open

Adds Sphere Object to sphere function in viz.actors#56
thechargedneutron wants to merge 61 commits into
Garyfallidis:cancer_spheresfrom
thechargedneutron:cancer_spheres_mod_version

Conversation

@thechargedneutron
Copy link
Copy Markdown

This change is inspired from https://github.com/nipy/dipy/blob/6bee25c1d25acc1437752be0e166acce42bfed84/doc/examples/viz_surfaces.py#L92 .
I am not sure of this addition would override the existing polyData. Even if it does, we can merge the different things later.
I may be on a wrong track. Please correct me if I am going wrong.

Ping @Garyfallidis .

Garyfallidis and others added 20 commits May 12, 2018 09:46
…tions

DOC: updated some developers affiliations.
1) This change will be reflected on the page http://nipy.org/dipy/examples_built/workflow_creation.html#example-workflow-creation
2) Added one more import statement to import the AppendTextFlow method from the workflow class.
3) Added few lines to explain why we need to import the methods.
1) The PEP8 still complains about the maximum line width but no complaints about the
trailing white spaces.
…e by Serge

1) Slightly modified the comments to tell that we are creating a separate file called as my_workflow.py in <dipy/workflows> folder.
2) Removed the first line about the import statements.
3) Comments are more precise now.
Moved some older highlights and announcements to the old news files.
Updating the documentation for the workflow creation tutorial.
Comment thread dipy/viz/actor.py Outdated
radii : float or ndarray, shape (N,)
theta : int
phi : int
sphere_obj : ndarray, shape (N,)
Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be a Sphere object.
or have different parameters for vertices and faces.

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But one object can only map to one sphere and we won't be able to map many spheres. Is this a desired behaviour?

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess array of objects suits our purpose. Having an object would make only one sphere. RIght?

@ranveeraggarwal
Copy link
Copy Markdown

@Garyfallidis @thechargedneutron what if we need to visualise just Sphere objects? I can see two ways here:

  1. A separate function to visualise Sphere objects.
  2. Checks in the existing function

@thechargedneutron
Copy link
Copy Markdown
Author

@ranveeraggarwal Yeah I forgot to consider the case when we do not pass anything except Sphere object. Both the solutions are legit and the implementation depends on the use case. Looks like check is an easy way out.

@Garyfallidis
Copy link
Copy Markdown
Owner

Garyfallidis commented May 20, 2018

@thechargedneutron, @ranveeraggarwal I had more thoughts about this. We shouldn't add a sphere object as one of the parameters. Because the viz parts will become an independent project. The Sphere object is strictly dipy related and will probably stay in dipy.
Create independent input variables vertices=None, faces=None and if they are not None then overrule theta and phi.

ShreyasFadnavis and others added 5 commits May 21, 2018 12:52
…atrix function in tracking.utils was corrected as True.
…-default-parameter-in-doc-for-symmetric

Wrong default value for parameter 'symmetric' connectivity_matrix function
MarcCote and others added 28 commits May 29, 2018 16:29
Update Rafael's current institution.
…tion

DOC: Update Rafael's current institution.
…n-example-reconst-dki

Explanation that is mistakenly rendered as code fixed in example of DKI
…ing2

Enh ui components positioning (with code refactoring)
fix potential zero division in demon regist.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.