Don't recursively walk local-only dirs with NO_DELETE#120
Merged
Conversation
I-Al-Istannen
requested changes
Jun 8, 2025
| return path in self.marked | ||
|
|
||
| def contains_marked(self, path: PurePath) -> bool: | ||
| return any(marked_file.is_relative_to(path) for marked_file in self.marked) |
Collaborator
There was a problem hiding this comment.
Maybe mark the parents and do not build an n² algo?
Collaborator
|
Did you update this in the end? |
I-Al-Istannen
force-pushed
the
no-delete-dirs
branch
from
6dae86d to
4ce7178
Compare
I-Al-Istannen
force-pushed
the
no-delete-dirs
branch
from
4ce7178 to
050d380
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR consolidates
not deletedreports/log messages for whole directories that are only available locally. This avoids the performance impact of recursively looking at local-only directories with a lot of files (for example venvs)