Skip to content

🎨 Palette: Enhance Rating UI and Detail Header Accessibility#64

Open
Gamepulse wants to merge 1 commit into
Devfrom
palette-enhance-rating-accessibility-17192082126027648974
Open

🎨 Palette: Enhance Rating UI and Detail Header Accessibility#64
Gamepulse wants to merge 1 commit into
Devfrom
palette-enhance-rating-accessibility-17192082126027648974

Conversation

@Gamepulse

Copy link
Copy Markdown
Owner

💡 What:

  • Added a "Clear Rating" button to the game detail header to allow users to unset their personal rating.
  • Converted the folder path from a <p> tag to a semantic <button> to improve keyboard accessibility.
  • Improved accessibility of the personal rating range input by adding a unique id and associating it with its <label>.
  • Removed an unused state variable hasIgdbId in GameScreenshotsCarousel.tsx that was causing build failures.

🎯 Why:

  • Native HTML range inputs do not support a "null" state, making it difficult to clear a rating once set.
  • Interactive elements should use semantic HTML tags to ensure they are discoverable and usable by keyboard and screen reader users.
  • Clean code and successful builds are essential for maintainability.

♿ Accessibility:

  • Used semantic <button type="button"> for the interactive folder path.
  • Added descriptive aria-label to buttons.
  • Associated form labels with inputs using id and htmlFor.
  • Marked decorative icons and secondary labels (like min/max bounds) with aria-hidden="true".
  • Added focus-visible styles for better keyboard navigation.

PR created automatically by Jules for task 17192082126027648974 started by @Gamepulse

- Add 'clearRating' translations (EN/FR)
- Add 'Clear Rating' button to GameDetailHeader
- Associate Personal Rating range input with label for a11y
- Convert folder path text to semantic button with a11y attributes
- Fix build error by removing unused 'hasIgdbId' in GameScreenshotsCarousel

Co-authored-by: Gamepulse <8333979+Gamepulse@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant