Skip to content

🎨 Palette: Add Clear Rating button and improve accessibility#61

Open
Gamepulse wants to merge 1 commit into
Devfrom
palette-rating-ux-a11y-improvements-3211844614363403799
Open

🎨 Palette: Add Clear Rating button and improve accessibility#61
Gamepulse wants to merge 1 commit into
Devfrom
palette-rating-ux-a11y-improvements-3211844614363403799

Conversation

@Gamepulse

Copy link
Copy Markdown
Owner

This PR introduces several micro-UX and accessibility improvements to the game detail header:

  • Clear Rating: Users can now reset their personal rating to an unset state (null) via a new 'Clear Rating' button that only appears when a rating is set.
  • Semantic HTML: The interactive folder path is now a semantic <button>, making it focusable and actionable for keyboard users.
  • Form Accessibility: The platform selector and personal rating slider now have unique IDs and are properly associated with their labels using htmlFor.
  • Keyboard Navigation: Added high-contrast focus-visible rings to all interactive elements in the header, including the favorite star, IGDB button, folder path, and tags.
  • Screen Reader Polish: Applied aria-hidden to decorative icons and provided descriptive aria-labels for icon-heavy buttons.
  • Build Fix: Removed an unused state variable in GameScreenshotsCarousel.tsx that was causing pnpm build to fail.

These changes make the game details more accessible and intuitive without altering the core design.


PR created automatically by Jules for task 3211844614363403799 started by @Gamepulse

…etailHeader

- Add 'clearRating' translation key in English and French.
- Add 'Clear Rating' button to reset personal rating to null.
- Convert interactive folder path from <p> to <button> for keyboard accessibility.
- Add proper <label> associations with unique IDs for platform selector and rating slider.
- Add consistent focus-visible styles (indigo rings) to all interactive header elements.
- Use aria-hidden on decorative icons and emojis.
- Fix pre-existing TypeScript error in GameScreenshotsCarousel.tsx (unused 'hasIgdbId').

Co-authored-by: Gamepulse <8333979+Gamepulse@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant