🎨 Palette: Improve Personal Rating UX and accessibility#60
Conversation
- Add "Clear Rating" button to allow unsetting game ratings - Associate rating range input with its label via unique ID - Add aria-hidden="true" to visual range bounds - Fix pre-existing build error (unused variable) in GameScreenshotsCarousel.tsx - Add translations for 'clearRating' in English and French Co-authored-by: Gamepulse <8333979+Gamepulse@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
1 participant
This PR introduces several micro-UX and accessibility improvements to the Personal Rating section in the Game Detail view:
nullstate, users were previously unable to "unset" a rating once selected. I've added a "Clear Rating" button (✕ Effacer la note / Clear Rating) that appears when a rating is set, allowing users to reset it.rating-range-${game.id}).aria-hidden="true"to prevent redundant announcements by screen readers.cursor-pointerto the label for a better hit area.GameScreenshotsCarousel.tsxwhere thehasIgdbIdstate was declared but never used.Verified visually with Playwright screenshots and passed
pnpm buildandpnpm test.PR created automatically by Jules for task 25789869176598812 started by @Gamepulse