Skip to content

🎨 Palette: Improve rating UX and card accessibility#57

Open
Gamepulse wants to merge 1 commit into
Devfrom
palette-rating-card-ux-14091871572349747328
Open

🎨 Palette: Improve rating UX and card accessibility#57
Gamepulse wants to merge 1 commit into
Devfrom
palette-rating-card-ux-14091871572349747328

Conversation

@Gamepulse

Copy link
Copy Markdown
Owner

💡 What: The UX enhancement added

  • Added a "Clear Rating" button in the Game Detail view to allow users to unset their personal rating.
  • Converted interactive tags and status badges in GameCard from <span> to semantic <button> elements.
  • Improved accessibility by adding proper <label> associations, aria-labels, and focus-visible styles.
  • Cleaned up an unused variable in GameScreenshotsCarousel.tsx to fix a build error.

🎯 Why: The user problem it solves

  • Users previously had no way to remove a personal rating once set (only move it between 0-100).
  • Keyboard users could not easily interact with tags or status badges on game cards as they weren't natively focusable.
  • Screen reader users lacked context for what the interactive tags and badges did.

♿ Accessibility: Any a11y improvements made

  • Replaced non-semantic role="button" with real buttons.
  • Added high-contrast focus rings for keyboard navigation.
  • Linked rating input to its label via id/htmlFor.
  • Added descriptive aria-labels to interactive elements.
  • Marked decorative icons with aria-hidden="true".

PR created automatically by Jules for task 14091871572349747328 started by @Gamepulse

- Add 'Clear Rating' button to GameDetailHeader
- Use semantic buttons for tags and status badges in GameCard
- Improve accessibility with proper labels and ARIA attributes
- Fix unused variable in GameScreenshotsCarousel.tsx

Co-authored-by: Gamepulse <8333979+Gamepulse@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant