Skip to content

🎨 Palette: Accessibility and UX improvements#56

Open
Gamepulse wants to merge 1 commit into
Devfrom
palette-ux-improvements-3729346484541871387
Open

🎨 Palette: Accessibility and UX improvements#56
Gamepulse wants to merge 1 commit into
Devfrom
palette-ux-improvements-3729346484541871387

Conversation

@Gamepulse

Copy link
Copy Markdown
Owner

This PR introduces several micro-UX and accessibility enhancements across the game management interface:

  1. Rating UX: Added a localized "Clear Rating" button next to the personal rating slider. Since HTML range inputs can't represent a 'null' state, this provides a clear way for users to unset their rating.
  2. Keyboard Accessibility:
    • Converted the clickable folder path in the game detail view from a <p> tag to a semantic <button type="button">.
    • Added descriptive aria-label to the folder path button, including the full path.
    • Ensured all icon-only buttons (Favorite, Quick Assign) have proper aria-label and title attributes.
    • Added aria-pressed to the Favorite button to communicate state to screen readers.
  3. Screen Reader Polish: Wrapped decorative emojis (🌐, 📁, 🎮) in <span aria-hidden="true"> to prevent redundant or confusing announcements.
  4. General Maintenance: Fixed a TypeScript lint error regarding an unused variable in GameScreenshotsCarousel.tsx to ensure the build passes.
  5. Internationalization: Added and used new translation keys for 'clearRating' and 'quickAssign' in both English and French.

Verified with pnpm build, pnpm test, and Playwright visual inspection.


PR created automatically by Jules for task 3729346484541871387 started by @Gamepulse

- Added 'Clear Rating' button to personal rating in GameDetailHeader
- Converted folder path to semantic button for keyboard accessibility
- Added ARIA labels and pressed states to favorite and quick assign buttons
- Hid decorative emojis from screen readers
- Fixed unused variable lint error in GameScreenshotsCarousel
- Added missing translations for new UX elements

Co-authored-by: Gamepulse <8333979+Gamepulse@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant