🎨 Palette: Improve GameDetailHeader accessibility and add clear rating#51
🎨 Palette: Improve GameDetailHeader accessibility and add clear rating#51Gamepulse wants to merge 1 commit into
Conversation
- Add 'clearRating' translation keys for English and French.
- Implement 'Clear Rating' button in GameDetailHeader to allow resetting personal ratings.
- Improve accessibility in GameDetailHeader:
- Add aria-label and focus-visible rings to favorite toggle.
- Hide slider boundary labels from screen readers using aria-hidden.
- Add aria-label to the rating range input.
- Properly associate platform selector label with its input.
- Fix pre-existing TypeScript error in GameScreenshotsCarousel.tsx (unused variable).
Co-authored-by: Gamepulse <8333979+Gamepulse@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
1 participant
This PR implements several micro-UX and accessibility improvements to the
GameDetailHeadercomponent.Key changes:
nullstate, which was previously difficult as the range input always forced a value.focus-visiblerings to interactive elements (Favorite toggle, Clear button, Range input) for better keyboard navigation.aria-labelto icon-only buttons and the range input.aria-hidden="true"to reduce noise.htmlForandid.hasIgdbIdstate fromGameScreenshotsCarousel.tsxthat was causing production build failures.These changes follow the project's design system and improve the overall usability and inclusiveness of the application.
PR created automatically by Jules for task 17588631665040963910 started by @Gamepulse